Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternate example data in OpenSearch test cases. #454

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Use alternate example data in OpenSearch test cases. #454

merged 3 commits into from
Mar 25, 2021

Conversation

adnapibar
Copy link
Contributor

This PR replaces some example data used in Elasticsearch.

As a result of this change, some test failures are also fixed which were failing due to incomplete renaming in test data and expected values in test cases.

Relates #441

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar added :test Adding or fixing a test >FORK Related to the fork process labels Mar 23, 2021
@adnapibar adnapibar requested a review from nknize March 23, 2021 23:59
@odfe-release-bot
Copy link

✅   DCO Check Passed cb0833a1c0b29a740de71b27c7fd81afaa150d37

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success cb0833a1c0b29a740de71b27c7fd81afaa150d37

@odfe-release-bot
Copy link

✅   Gradle Precommit success cb0833a1c0b29a740de71b27c7fd81afaa150d37

@odfe-release-bot
Copy link

✅   DCO Check Passed 030abe67eae71886e0eb6bf7bf1418d364bf5eea

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 030abe67eae71886e0eb6bf7bf1418d364bf5eea

@odfe-release-bot
Copy link

✅   Gradle Precommit success 030abe67eae71886e0eb6bf7bf1418d364bf5eea

@adnapibar adnapibar added Rename Renaming to OpenSearch and removed :test Adding or fixing a test labels Mar 24, 2021
@adnapibar adnapibar mentioned this pull request Mar 24, 2021
77 tasks
@adnapibar adnapibar closed this Mar 24, 2021
This commit updates some of the sample test data used in test cases in OpenSearch.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar reopened this Mar 24, 2021
@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 25ba05b

@odfe-release-bot
Copy link

✅   DCO Check Passed 25ba05b

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed 31f41ca

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 31f41ca

@odfe-release-bot
Copy link

✅   Gradle Precommit success 25ba05b

@odfe-release-bot
Copy link

✅   Gradle Precommit success 31f41ca

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other real aliases that we should scrub. I just grabbed more metasyntactic variables

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 2ebf0d6

@odfe-release-bot
Copy link

✅   DCO Check Passed 2ebf0d6

@odfe-release-bot
Copy link

✅   Gradle Precommit success 2ebf0d6

@adnapibar adnapibar requested a review from nknize March 25, 2021 01:11
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nknize
Copy link
Collaborator

nknize commented Mar 25, 2021

Don't forget to backport to 1.x!

@harold-wang harold-wang self-requested a review March 25, 2021 15:28
Copy link
Contributor

@harold-wang harold-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please merge, I will close #456 .

@adnapibar adnapibar merged commit 0bdd129 into opensearch-project:main Mar 25, 2021
@adnapibar adnapibar deleted the sample-test-data branch March 25, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants